You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Money Account deposits could not submit: Max was the only amount that cleared the footer, other amounts showed insufficient funds, a $0 pay token left the amount on a skeleton, and switching tokens crashed on a high-precision BigNumber rate.
This aligns deposit encode and Max with mobile (ROUND_DOWN, non-atomic Max), compares the live funding-account balance instead of the money-account snapshot, converts deposit USD with the mUSD rate (not Monad/vault), and shows 0.0 when the selected token has no balance.
Build and load this branch (yarn start) with the Money Account feature flag enabled and a wallet that has a Money Account plus a small funding balance (for example ETH or a stablecoin).
Start Add funds from the Money Account.
Confirm Pay with is a token that has a balance, not destination mUSD at $0.00.
Tap Max and confirm the footer allows Add funds.
Tap 10%, 25%, and 50%, and type an amount below the Pay-with balance. Confirm the footer still allows Add funds.
Type an amount above the Pay-with balance. Confirm the footer blocks with insufficient funds.
Open Pay with, select a different token, and confirm the confirmation does not crash.
If Pay with is a $0 token, confirm the amount shows 0.0 instead of a skeleton.
Submit a Max deposit and a non-Max deposit and confirm both complete.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
Pre-merge reviewer checklist
I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Bundle size diffs [🚨 Warning! Bundle size has increased!]
background: 121.57 KiB (0.83%)
ui: 23.61 KiB (0.12%)
common: 0 Bytes (0%)
other: 0 Bytes (0%)
contentScripts: 8.96 KiB (0.47%)
zip: 41.89 KiB (0.19%)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-changelogno-changelog Indicates no external facing user changes, therefore no changelog documentation neededsize-XLteam-confirmationsPush issues to confirmations team
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Money Account deposits could not submit: Max was the only amount that cleared the footer, other amounts showed insufficient funds, a $0 pay token left the amount on a skeleton, and switching tokens crashed on a high-precision BigNumber rate.
This aligns deposit encode and Max with mobile (ROUND_DOWN, non-atomic Max), compares the live funding-account balance instead of the money-account snapshot, converts deposit USD with the mUSD rate (not Monad/vault), and shows
0.0when the selected token has no balance.Stacked on #45543.
Changelog
CHANGELOG entry: Fixed Money Account deposits failing to submit or showing insufficient funds for amounts other than Max
Related issues
Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1743
Manual testing steps
yarn start) with the Money Account feature flag enabled and a wallet that has a Money Account plus a small funding balance (for example ETH or a stablecoin).0.0instead of a skeleton.Pre-merge author checklist
Pre-merge reviewer checklist